Fix OE broken links #977
Merged
Fix OE broken links #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-thompson
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Not personally a fan of the simplifications. My instinct would always be to include the field separators in the globs since that better records the authors intent about what fields they intended to wildcard (taking a simple glob like myboard-* we can see there was no intent to match myboardv2-0.1).
However this is a conviction weakly held and I can live with the alternatives proposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified some of the regular expressions to make more readable while I was at it.