WIP: integrate sbt-doctest #1260
Draft
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1260 +/- ##
===========================================
+ Coverage 53.92% 53.94% +0.01%
===========================================
Files 431 431
Lines 8070 8070
Branches 365 365
===========================================
+ Hits 4352 4353 +1
+ Misses 3718 3717 -1 |
neko-kai
force-pushed
the
feature/doc-test
branch
from
b5b1b76
to
5cae759
Compare
|
|
Jeez, I'm so sorry, somehow, I've just missed a notification about this 🤦 . I didn't ignore this, just missed it out, sorry. |
|
@VladPodilnyk no worries! |
pshirshov
force-pushed
the
develop
branch
2 times, most recently
from
be4d382
to
6dda1f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current blocker:
sbt-doctestgenerates test files inside the current artifact's test scope, but e.g. code examples indistage-core-apiforward-reference classes that are only available indistage-coreand onward — they cannot compile indistage-core-api / testscope. Now, this parameter the directory to dump source files to is controlled by this line https://github.com/tkawachi/sbt-doctest/blob/master/src/main/scala/com/github/tkawachi/doctest/DoctestPlugin.scala#L103, if we provide an alternative definition fordoctestGenTeststhat uses a different key instead ofmanagedSourceDirectories in Test, we could override that key and dump the tests into a different directory (e.g.microsite- where all the libraries are available at the same time)/cc @vpodlnk @VladPodilnyk - would you be interested in exploring this task?