Skip to content

Commit

Permalink
config_tools: fix pre_launch VM ACPI table
Browse files Browse the repository at this point in the history
Current acpi table adopts the DWordAddressSpace to
present the PCI hole above 4G. It is not correct,
because DWordAddressSpace is used to present the
mem space below 4G.
Follow the ACPI spec, modify to QWordAddressSpace here.

Refer: 19.6.22. CreateQWordField (Create 64-Bit Buffer Field)

Tracked-On: projectacrn#8552
Signed-off-by: Zhangwei6 <wei6.zhang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
  • Loading branch information
6ZhangWei committed Jan 25, 2024
1 parent 852f10c commit 1bc8c4c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions misc/config_tools/acpi_gen/asl_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,12 @@ def gen_root_pci_bus(path, prt_packages):
resources.append(res)

# The PCI hole above 4G
qword_address_space_cls = rdt.LargeResourceItemQWordAddressSpace_factory()
res = create_object(
dword_address_space_cls,
qword_address_space_cls,
type = 1, # Large type
name = rdt.LARGE_RESOURCE_ITEM_ADDRESS_SPACE_RESOURCE,
length = ctypes.sizeof(dword_address_space_cls) - 3,
name = rdt.LARGE_RESOURCE_ITEM_QWORD_ADDRESS_SPACE,
length = ctypes.sizeof(qword_address_space_cls) - 3,
_TYP = 0, # Memory range
_DEC = 0, # Positive decoding
_MIF = 1, # Minimum address fixed
Expand Down

0 comments on commit 1bc8c4c

Please sign in to comment.