M1 Bugfix | Parameters checking of Metrics Reporting Configurations #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stojkovicv
changed the title
dsilhavy
reviewed
Mar 18, 2024
|
Superceded by PR #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decription
This pull request provides additional values checking for a M1 Metrics Reporting Configurations. This corrects M1 Metrics operations in terms of preventing provisioning with an unreasonable values for reporting interval and sampling period.
Related issues: #145 , #146
Changes
Two operations are affected: Create & Update. In case of invalid input, the server will respond with 422 Unprocessable Entity with detailed message about wrong values.