Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13 Change adapter items count to reproduce last row not filled #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

indriks
Copy link

@indriks indriks commented Jan 17, 2017

Add feature in GreedoLayoutSizeCalculator to adjust last row height to fit entire width.

add feature in GreedoLayoutSizeCalculator to adjust last row height to fit entire width
@indriks
Copy link
Author

indriks commented Jan 31, 2017

Any updates on pull request?

@mck182
Copy link
Contributor

mck182 commented Feb 9, 2017

Hey Ivars,

thanks a lot for your contribution! We have reviewed your
patch and we agree it's a nice addition. We'd like to however
not have this behavior on by default - it's fine when you know
in advance which images will be in your grid and you can be
certain that the last image won't be a portrait for example,
but not so much when the images are unknown beforehand.

This is where it gets problematic - consider the last image is
a thin and tall portrait - it gets scaled to full width but with that
the height also grows and can actually overgrow the display
height. Such behavior can be seen in the sample app if you change
the IMAGE_COUNT to 488; on Nexus 5X the last image fills
almost entire display.

So this is where we see your solution fall short. Do you think you
could make it more robust for these cases?

Thanks,
Martin, 500px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants