Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for sharing endpoint. #6220

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Add documentation for sharing endpoint. #6220

merged 2 commits into from
Jan 30, 2020

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Jan 28, 2020

For https://github.com/4teamwork/gever-ui/issues/864

Checkliste

  • Changelog-Eintrag vorhanden/nötig?
  • Aktualisierung Dokumentation vorhanden/nötig?

@njohner njohner requested a review from a team January 28, 2020 16:14
deiferni
deiferni approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@deiferni deiferni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos/german. Proposed fix in comment. LGTM otherwise 👍.

As just discussed i don't get the point of the ignore_permissions parameter, but we'll discuss that later 😉

docs/public/dev-manual/api/sharing.rst Outdated
Sharing
=======

Die lokalen Rollen können mit dem ``@sharing`` Endpoint abgefragt werden. Um die Lokalen Rollen aufzulisten ohne Berechtigungen um sie zu bearbeiten muss mann der Parameter ``ignore_permissions=True`` setzten.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um die Lokalen Rollen aufzulisten ohne Berechtigungen um sie zu bearbeiten muss mann der Parameter ignore_permissions=True setzten.

->

Um die lokalen Rollen aufzulisten, wenn man keine Berechtigungen zum Bearbeiten hat, muss man den Parameter ignore_permissions=True setzen.

@njohner
Copy link
Contributor Author

njohner commented Jan 30, 2020

Opened a follow-up issue to clarify the intent of that endpoint: #6221

@njohner njohner force-pushed the nj_sharing branch 6 times, most recently from be842ec to b7c88c5 Compare January 30, 2020 10:32
@njohner njohner merged commit 8eebfc2 into master Jan 30, 2020
@njohner njohner deleted the nj_sharing branch January 30, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deiferni deiferni deiferni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@njohner @deiferni