Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio player remove improvements #443

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ScrubN
Copy link

@ScrubN ScrubN commented Dec 31, 2023

Changes:

  • Add X hotkey for removing the currently selected audio in the audio player.
    • I was a bit conflicted on this choice. I would have preferred del, but since it is used to clear hotkeys in the settings window, it was not an option. My next choice was D but I wanted to avoid conflicting hotkeys, even if they were from different windows. Eventually I settled on borrowing Blender's delete key, D.
  • Stop playback if the removed file was the currently playing file
  • Clear state related to the currently playing audio if the last audio was removed from the playlist.

If there are any changes you would like made to this PR, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant