Some review changes.

4ian · Apr 29, 2024 · 02314a2 · 02314a2
1 parent 9860c9c
commit 02314a2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/newIDE/app/src/EventsSheet/index.js b/newIDE/app/src/EventsSheet/index.js
@@ -1943,7 +1943,7 @@ export class EventsSheetComponentWithoutHandle extends React.Component<
                   }
                   onParameterClick={this.openParameterEditor}
                   onVariableDeclarationClick={() => {
-                    //TODO
+                    // Nothing to do.
                   }}
                   onVariableDeclarationDoubleClick={this.openVariablesEditor}
                   onEventClick={this.selectEvent}

diff --git a/newIDE/app/src/UI/Theme/Global/EventsSheet.css b/newIDE/app/src/UI/Theme/Global/EventsSheet.css
@@ -93,7 +93,7 @@
   padding-left: 5px;
   padding-right: 5px;
   /* Prevent container to growing outside its parent. We don't have a way to prevent an infinitely
-     * small action column, but responsive design should avoid the problem on small screens. */
+     * small variables column, but responsive design should avoid the problem on small screens. */
   min-width: 0;
 }
 

diff --git a/newIDE/app/src/VariablesList/VariablesList.js b/newIDE/app/src/VariablesList/VariablesList.js
@@ -540,13 +540,15 @@ const VariablesList = (props: Props) => {
   );
   const setSelectedNodes = React.useCallback(
     (nodes: Array<string> | ((nodes: Array<string>) => Array<string>)) => {
-      nodes = Array.isArray(nodes) ? nodes : nodes(selectedNodes);
-      doSetSelectedNodes(nodes);
-      if (onSelectedVariableChange) {
-        onSelectedVariableChange(nodes);
-      }
+      doSetSelectedNodes(selectedNodes => {
+        const newNodes = Array.isArray(nodes) ? nodes : nodes(selectedNodes);
+        if (onSelectedVariableChange) {
+          onSelectedVariableChange(newNodes);
+        }        
+        return newNodes;
+      });
     },
-    [onSelectedVariableChange, selectedNodes]
+    [onSelectedVariableChange]
   );
 
   const [searchMatchingNodes, setSearchMatchingNodes] = React.useState<