Correctly split three-or-more byte sequences of UTF-8 #2123
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit d9c1df7 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying bug was the assumption that
uft8.DecodeLastRuneInStringreturns some kind of number of bytes that, when stripped from the end, leaves the string with a correct ending.In reality, this function always returns the constant value 1 if the last rune is not valid.
Therefore, if there are two or more partial bytes of a three-or-more byte rune, this used to give the wrong result.
Found while trying to implement a related feature.