Add support for discord forum channels/threads (discord) #1914
Conversation
|
@tomabrafix sorry for the long delay on response for this PR, are you still willing to work on it and rebase it? |
|
any update on tis? |
Might take a look at this later... a bit busy these days :P |
tomabrafix
force-pushed
the
discord-forum-threads
branch
from
0ac10a4
to
11a6985
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| // Returns messageID and error. | ||
| func (b *Bdiscord) webhookSend(msg *config.Message, channelID string) (*discordgo.Message, error) { | ||
| func (b *Bdiscord) webhookSendThread(msg *config.Message, channelID string, threadID string) (*discordgo.Message, error) { |
There was a problem hiding this comment.
Method Bdiscord.webhookSendThread has 52 lines of code (exceeds 50 allowed). Consider refactoring.
There was a problem hiding this comment.
I do not think a shorter function (even by two lines) will improve the understanding of this code. Is it possible to ignore the "issue" at this point?
|
Merge it merge it |
Messages send to forum threads need to use the ID of the forum for the webhook but also need to set an additional parameter during the API call to specify the destination thread. Receiving messages from threads works by using the thread ID. The forum ID is not required. This commit adds an optional channel option "ForumID" which can be used to supply the forum ID of a thread (= channel). When sending/editing messages the ForumID will be used for the webhook and the channel ID will be supplied as the additional parameter "thread_id". Fixes 42wim#1908
tomabrafix
force-pushed
the
discord-forum-threads
branch
from
11a6985
to
3e3090f
Compare
|
Code Climate has analyzed commit 3e3090f and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
I currently use matterbridge to bridge an IRC and a discord server. This feature would greatly improve the user experience, is it ready to merge ? |
|
From my point of view it can be merged |
|
How would i use this to mirror i.e. slack threads with discord threads? |
If I understand Slack correctly, Slack Threads and Discord "Threads" are different concepts and should not be mirrored: |
I'm not talking about forum channels in Discord, I'm talking about threads within normal channels, which is a feature released around 1 year ago. You can have threads in normal channels as well now (see: https://support.discord.com/hc/en-us/articles/4403205878423-Threads-FAQ ). The slack thread <> discord reply feature is nice, but Discord threads would be better and more intuitive. By the way, do you have some fork of this that is being more actively maintained that I could use, with all your features upstreamed to some main branch? Here I have to choose between one feature or another based on which branch is making the PR... |
Messages send to forum threads need to use the ID of the forum for the webhook but also need to set an additional parameter during the API call to specify the destination thread.
Receiving messages from threads works by using the thread ID. The forum ID is not required.
This commit adds an optional channel option "ForumID" which can be used to supply the forum ID of a thread (= channel). When sending/editing messages the ForumID will be used for the webhook and the channel ID will be supplied as the additional parameter "thread_id".
Fixes #1908