-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strict equality operator to TS files src/* #754
base: master
Are you sure you want to change the base?
Add strict equality operator to TS files src/* #754
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
==========================================
- Coverage 82.62% 82.58% -0.04%
==========================================
Files 141 141
Lines 11496 11493 -3
Branches 2126 2126
==========================================
- Hits 9498 9492 -6
+ Misses 1667 1665 -2
- Partials 331 336 +5 ☔ View full report in Codecov by Sentry. |
@dkoes Could you kindly review and let me know if there are any other changes to be made? |
UPDATE: Removed |
…into strict-equality-ts-01
💫 Changelog
⭐ Updates TS files
src/*
to use strict equality operator.⭐ Only those conditions are updated where it is safe to update
==
to===
and!=
to!==
. (E.g: statements where types of both the operands are known and same, operands that usetypeof
etc.)⭐ There still exist several statements where the operator is not updated as the logic might change (
==
returns true on comparingnull
andundefined
whereas===
returns false) or the types of operands are not known (any
). Updating this requires manual efforts and it'll be easier once the type safety of the library has been improved.⭐ The operators still need to be updated in these paths:
src/parsers
,src/WebGL
which will be done on a separate PR (because it'll be difficult to self-review large file changes before submitting PR)