Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain list state after config change #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

josephkreiser
Copy link

  • Move setting of pager adapter so that list fragment state is restored after config change

    • After a config change (such as screen rotation), a ViewPager2's state is restored when its adapter is set. If the adapter is set before the backing data is set, then each of the ViewPager2's page Fragment's states won't be restored as expected. By moving the setting of the adapter after the adapter's data is set, it allows the currently selected tab to be restored as well as the scroll position of the RecyclerViews in the list Fragments.
  • Set the current tab to today only once on startup so that after a config change, it won't change the user's currently selected tab

  • Fix date string

… after config change

After a config change (such as screen rotation),
a ViewPager2's state is restored when its adapter is set.  If the adapter is set before
the backing data is set, then each of the ViewPager2's page Fragment's states won't
be restored as expected.  By moving the setting of the adapter after the adapter's
data is set, it allows the currently selected tab to be restored as well as the scroll
position of the RecyclerViews in the list Fragments.
…fig change, it won't change the user's currently selected tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant