Filtering out URLs whose parsing encounter UnicodeDecodeError #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduous
changed the title
Arduous
force-pushed
the
PRforbug6
branch
3 times, most recently
from
c9cb167
to
78d935c
Compare
Signed-off-by: Samuel Progin <samuel.progin@gmail.com>
|
Hello, I did some cleanup in my commits. Any chance to get this pull request accepted? Thank you |
|
Hi, so sorry, been super busy with work lately I'll try to reproduce this and get a better understanding of what's actually happening there, will merge once I confirm this solves it 😄 Thanks for the PR |
Signed-off-by: Samuel Progin <samuel.progin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to protect from exceptions described in bug #6 .
Commits are messy :/ but at the end of the day, changes are really limited.