Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods.18f.gov from redirect_bases yaml. #477

Merged
merged 5 commits into from Feb 29, 2024

Conversation

cannandev
Copy link
Contributor

@cannandev cannandev commented Feb 13, 2024

Changes proposed in this pull request:

✅ Remove methods.18f.gov URL from redirect_bases.yaml, according to the steps to migrate a guide

⚠️ Since this is the last site to be migrated, there is no longer a need for the redirect check. This PR removes the check from the pull request.

Background info:

During the replatforming, we wanted to make sure we redirected guides that were “not yet ready” to the live "production" versions. We checked the meta refresh tag (frontend redirects) to make sure the tag is present when in the production environment, not dev. Now that all sites are live, the checks are no longer relevant.

Preview

👀 Methods Preview URL

@cannandev cannandev requested a review from a team as a code owner February 13, 2024 09:31
@cannandev cannandev linked an issue Feb 13, 2024 that may be closed by this pull request
9 tasks
@cannandev cannandev marked this pull request as draft February 13, 2024 17:11
@cannandev cannandev marked this pull request as ready for review February 26, 2024 17:58
package.json Outdated Show resolved Hide resolved
@cannandev cannandev merged commit 94c34ed into main Feb 29, 2024
6 checks passed
@cannandev cannandev deleted the 237-launch-new-methods-site branch February 29, 2024 15:57
@cannandev cannandev mentioned this pull request Mar 4, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch new Methods site
2 participants