Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace blockquote div with blockquote element #3826

Merged
merged 2 commits into from Apr 25, 2024
Merged

Replace blockquote div with blockquote element #3826

merged 2 commits into from Apr 25, 2024

Conversation

kbighorse
Copy link
Contributor

Pull request summary

Use blockquote element for blockquotes.

(Optional) Closes #(issue_number)].

Reminder - please do the following before assigning reviewer

  • Update readme
  • For frontend changes, ensure design review
  • For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introdcued

@kbighorse kbighorse requested a review from a team as a code owner April 19, 2024 01:38
@kbighorse kbighorse marked this pull request as draft April 19, 2024 01:38
@kbighorse kbighorse marked this pull request as ready for review April 19, 2024 20:48
@kbighorse kbighorse self-assigned this Apr 19, 2024
juliaklindpaintner
juliaklindpaintner approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@juliaklindpaintner juliaklindpaintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me — checked on 2 blog posts.

@kbighorse kbighorse merged commit 52a6d4e into main Apr 25, 2024
5 checks passed
@kbighorse kbighorse deleted the restyle-blockquotes branch April 25, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaklindpaintner juliaklindpaintner juliaklindpaintner approved these changes

@igorkorenfeld igorkorenfeld Awaiting requested review from igorkorenfeld

Assignees

@kbighorse kbighorse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbighorse @juliaklindpaintner