New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post and new author #3810
Conversation
Creates a new blog post
Add author Amanda Kennedy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing a stray -
character
I'm trying to figure out why the preview build isn't working
Add missing tag
Trying to get rid of indentation in h3 headers at the bottom of the post...
Deletes stray URL
Make Mad Libs style suggestion code snippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
@amandarkennedy Can you take a look at this preview of the post and see if you're happy with it? @quarterback is OOO today, but I will merge to publish — just wanted to get another set of eyes on it first. |
@juliaklindpaintner the only thing I noticed is that the following methods-related headers are now h1 when they were just bolded normal text in the draft. At the very least, I would prefer they be h2, but otherwise looks good. |
@amandarkennedy They are actually h3s already (the other headings are h2 and the title of the post is h1), but let me adjust to make them just be bolded. |
Change h3s to bolded text
@juliaklindpaintner that would be great, thanks! |
@amandarkennedy How about this? |
@juliaklindpaintner this looks great! One more thing I just realized: "Choose your method" doesn't follow the same framing of the other headers in the form of a question. Would it be possible to change it to "What method should you choose?" I am happy to do that (or leave as is). |
I see what you're saying @amandarkennedy. The last heading is also a different format ("Implement") — are you okay with that one? |
@juliaklindpaintner good question, and yes! I am okay with keeping |
Update heading
Okay! One last check of this preview? If it looks good, you can go ahead and approve this PR :) |
I'm around. and it looks good |
Pull request summary