Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post and new author #3810

Merged
merged 9 commits into from Mar 5, 2024
Merged

Conversation

juliaklindpaintner
Copy link
Member

Pull request summary

  • Adds @amandarkennedy as an author
  • Adds blog post "Customer experience: beyond surveys"

Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest removing a stray - character

I'm trying to figure out why the preview build isn't working

_posts/2024-03-05-customer-experience-beyond-surveys.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@juliaklindpaintner
Copy link
Member Author

@amandarkennedy Can you take a look at this preview of the post and see if you're happy with it? @quarterback is OOO today, but I will merge to publish — just wanted to get another set of eyes on it first.

@amandarkennedy
Copy link
Contributor

@juliaklindpaintner the only thing I noticed is that the following methods-related headers are now h1 when they were just bolded normal text in the draft. At the very least, I would prefer they be h2, but otherwise looks good.
Screenshot 2024-03-05 at 9 24 25 AM

@juliaklindpaintner
Copy link
Member Author

juliaklindpaintner commented Mar 5, 2024

@amandarkennedy They are actually h3s already (the other headings are h2 and the title of the post is h1), but let me adjust to make them just be bolded.

@amandarkennedy
Copy link
Contributor

@juliaklindpaintner that would be great, thanks!

@juliaklindpaintner
Copy link
Member Author

@amandarkennedy How about this?

@amandarkennedy
Copy link
Contributor

@juliaklindpaintner this looks great! One more thing I just realized: "Choose your method" doesn't follow the same framing of the other headers in the form of a question. Would it be possible to change it to "What method should you choose?" I am happy to do that (or leave as is).

@juliaklindpaintner
Copy link
Member Author

I see what you're saying @amandarkennedy. The last heading is also a different format ("Implement") — are you okay with that one?

@amandarkennedy
Copy link
Contributor

@juliaklindpaintner good question, and yes! I am okay with keeping Implement as is. Thanks for checking!

@juliaklindpaintner
Copy link
Member Author

Okay! One last check of this preview? If it looks good, you can go ahead and approve this PR :)

@amandarkennedy amandarkennedy merged commit 7177381 into main Mar 5, 2024
2 checks passed
@amandarkennedy amandarkennedy deleted the cx-beyond-surveys-amanda-kennedy branch March 5, 2024 15:04
@quarterback
Copy link
Contributor

I'm around. and it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants