Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guides.yml #3809

Merged
merged 1 commit into from Mar 4, 2024
Merged

Update guides.yml #3809

merged 1 commit into from Mar 4, 2024

Conversation

cannandev
Copy link
Contributor

@cannandev cannandev commented Feb 26, 2024 •
edited

Pull request summary

Updates homepage link to the Methods site. Clicking Design Methods should now take you to guides.18f.gov/methods

How to test

Go to the preview URL and click the Design Methods link

image

Reminder - please do the following before assigning reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introdcued

@cannandev cannandev marked this pull request as ready for review March 4, 2024 16:14
@cannandev cannandev requested a review from a team as a code owner March 4, 2024 16:14
juliaklindpaintner
juliaklindpaintner approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@juliaklindpaintner juliaklindpaintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉🎉

@cannandev cannandev merged commit 03b3d77 into main Mar 4, 2024
2 checks passed
@cannandev cannandev deleted the cannandev-update-methods-url branch March 4, 2024 16:45
@cannandev cannandev mentioned this pull request Mar 4, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaklindpaintner juliaklindpaintner juliaklindpaintner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cannandev @juliaklindpaintner