Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If window size is bigger than screen resolution, window cannot be moved #155

Open
fossegutten opened this issue Dec 14, 2019 · 8 comments
Open
Labels
Area: High DPI Support Issues relating to high DPI rendering. The bane of every engine dev's life. Area: Platform Issues relating to the platform layer Status: Needs Replicating Indicates that the issue cannot be replicated - this doesn't necessarily mean it's invalid! Type: Bug Problems with the code/documentation that need to be fixed.

Comments

@fossegutten
Copy link

fossegutten commented Dec 14, 2019

If i use really big resolution like 10000 by 10000, the window isn't even visible, because of negative position.
This could be prevented by preventing window position being less than 0,0

@17cupsofcoffee
Copy link
Owner

17cupsofcoffee commented Dec 14, 2019

Ah, yeah, the window is currently always centered when the game opens - I wouldn't really consider this a bug, as this is the behaviour I'd expect based on the code as it stands, but it might be something we want to change in the future.

@17cupsofcoffee 17cupsofcoffee changed the title Bug: If window size is bigger than screen resolution, window cannot be moved If window size is bigger than screen resolution, window cannot be moved Dec 14, 2019
@17cupsofcoffee 17cupsofcoffee added Area: Platform Issues relating to the platform layer Type: Feature Request Improvements that could be made to the code/documentation. labels Dec 14, 2019
@fossegutten
Copy link
Author

I think it is a bug, because if you cant even see the window if it is too big, and it's not centered. Window size should probably be clamped to the size of the monitor at creation?

@17cupsofcoffee
Copy link
Owner

When you say that you can't see the window, do you mean that the entire window goes invisible, or just that you can't see the window's frame?

@fossegutten
Copy link
Author

the Whole window

@17cupsofcoffee
Copy link
Owner

Huh 🤔 I wasn't able to replicate that on my machine, hence the misunderstanding - when I made the window bigger than my screen resolution, the window just appears bigger than the screen (almost as if it's in fullscreen but zoomed in).

@17cupsofcoffee 17cupsofcoffee added Type: Bug Problems with the code/documentation that need to be fixed. Status: Needs Replicating Indicates that the issue cannot be replicated - this doesn't necessarily mean it's invalid! and removed Type: Feature Request Improvements that could be made to the code/documentation. labels Dec 15, 2019
@17cupsofcoffee
Copy link
Owner

Marking this as 'could not replicate' for now, as I can't find a way to trigger the bug on my machine. My hunch is that this is an issue in SDL2, as I pretty much just pass the window size straight through to it.

@fossegutten
Copy link
Author

Try to enable some windows scaling above 100%, you might be able to replicate it then. I causes lots of problems for me.

@17cupsofcoffee
Copy link
Owner

Ooh, yeah, hadn't considered it might be due to DPI issues. I'll have a play around with that when I get the chance 👍

@17cupsofcoffee 17cupsofcoffee added the Area: High DPI Support Issues relating to high DPI rendering. The bane of every engine dev's life. label Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: High DPI Support Issues relating to high DPI rendering. The bane of every engine dev's life. Area: Platform Issues relating to the platform layer Status: Needs Replicating Indicates that the issue cannot be replicated - this doesn't necessarily mean it's invalid! Type: Bug Problems with the code/documentation that need to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants