Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toc docs reorg #364

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Toc docs reorg #364

wants to merge 23 commits into from

Conversation

Chr1st0ph3rTurn3r
Copy link
Contributor

No description provided.

sidebars.js Outdated
"config_audit_event",
"config_dhcp",
"config_dns_proxy",
"config_forward_error_correction",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will notice that some of the sidebar labels for configuration have "configuring x y and z" and many are just "feature name". We should be consistent. My preference is that since they are already in the configuration category, they do not need the sidebar label "configuring ..."

"initializer_cli_reference",
"initializer_preferences",
"Glossary": [
"concepts_glossary",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps remove the glossary category and move this item into concepts, or vice versa.

],
"Ethernet Over SVR": [
"concepts_EthOverSVR",
"config_EthoSVR",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you have pulled some of these config items out into their own respective feature heading. Should they be duplicated in the configuration section as well so someone can find it in either location?

Additionally, should each of the features be in their own "Features" category and start a 3-nested deep section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants