Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHP autosuggest placeholder is not being used. #1619

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fabianmarz
Copy link
Contributor

@fabianmarz fabianmarz commented Jan 10, 2020

Description of the Change

  • While the autosuggest search string placeholder value can be changed via a PHP hook, it's not picked up by the autosuggest JS and therefore the query will break or doesn't deliver the correct results.

Alternate Designs

  • Instead of deleting const placeholder = 'ep_autosuggest_placeholder'; I considered using const placeholder = queryJSON.placeholder; but decided to drop the line completely as the placeholder is used in buildSearchQuery() only.

Benefits

  • Don't break any the results if other than the default value is used :)

Possible Drawbacks

  • X

Verification Process

  • Inspected the query after the search and replace was done to ensure the query runs with the actual search term.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

  • Didn't find any.

Changelog Entry

@tlovett1
Copy link
Member

@mustafauysal can you review this one?

@mustafauysal
Copy link
Contributor

@tlovett1 looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants