Feature/selected border color #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erColor is not null when onRegionSelect and onRegionDeselect occur
xoxefdp
force-pushed
the
feature/selected-border-color
branch
from
3a58d0e
to
3375f40
Compare
xoxefdp
force-pushed
the
feature/selected-border-color
branch
from
0b342bd
to
532f0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
adds a parameter that enables region border to change when onRegionSelect or onRegionDeselect occurs if parameter not null
How should this be tested ?
adding selectedBorderColor: #color / rgba( color, opacity ) to jqvmap selector object, check border color changes when region selects and deselects
What are the relevant issues ?
None, it is a feature
This Pull Request includes:
npm testnpm testnpm testFYI tests didn't pass even in original master branch
What gif best describes how you feel about this work ?