-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaslLibrary should validate the code it compiles #1295
Comments
I split the above into multiple, smaller issues. Some of them may already be worked on, or even fixed on some of the existing PRs. |
I wonder if this issue is going to remain relevant once we switch to distributing MAST instead (which I expect to happen shortly after 1277 is merged, as the next in that series of changes):
As part of that switch, the new package format would also be introduced and used in place of MASL libraries. As a result, I'm not sure MASL libraries will even need to exist at that point. So I suppose my question is: do we try to address these issues before that happens, or do we address them in the switch to MAST? |
My preference would be to fix this as a part of transition to MAST-based libraries. |
miden-base
usesMaslLibrary::read_from_dir
to compile the rollup stdlibMaslLibrary
only parses the code withModuleAst::parse
AccountCodeAssemblerError(ReExportedProcModuleNotFound(..., name: ProcedureName { name: "receive_asset" }))
, which is very deceiving.exec
s referencing a module with broken codeAccountCodeAssemblerError(ParamOutOfBounds(1, 0, 0))
, which is the right error but no useful contextThe text was updated successfully, but these errors were encountered: