-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MASM errors should track origin #1298
Comments
I think compilation errors will have that as a part of #1277 (but @bitwalker can correct if I'm off here). Proving this info for runtime errors will take more work though. |
Yep! During my refactoring, I made most source-related errors associated with a source span, so that those errors render a source code snippet when displayed. There are still errors that lack spans, but these can be addressed one-by-one after 1277 is merged. |
Note: This should include advice instructions, for example:
Is not a useful error at all. |
are we planning on making a new vm release? this is still a pain point, specially for error results that don't have error codes, like Edit: Btw, question, it seems none of the |
We are - but first we need to migrate to MAST-based program serialization. I think we should try to get this done (and the new version of the VM released) but early/mid June.
#1277 improved error reporting during the assembly phase only. Improving error reporting (i.e., adding source locations) during program execution is still outstanding and will probably be a separate task (which will happen after the next release). |
Context: #1295
When errors are generated, they should track their source location as in source file, line, and column, to make it easier to find the root cause.
The text was updated successfully, but these errors were encountered: