cards-manifest: Use correct set name. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for the PR, currently master branch is outdated and from before the release of the public beta and includes the base set, tokens, and shop items that can only be obtained ingame. I've been away on holiday and will be updating the repo this week with all the new data and assets from the API and game files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first set is actually called "Call to Arms".
https://playartifact.com/news/1714079766522391429
Also, how do you get the 280 "Count" value? You have 300 entries in the cards array, but there are cards missing. For example https://www.artifactfire.com/artifact/cards/march-of-the-machines
The collectible card count is also just 237, according to the Steam market. So the 280 seems incorrect to me in any way.