-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discontinue the chain after the snapshot height finalizes #926
Discontinue the chain after the snapshot height finalizes #926
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #926 +/- ##
============================================
Coverage 96.89% 96.89%
============================================
Files 14 14
Lines 258 258
Branches 14 14
============================================
Hits 250 250
Misses 8 8 |
474606e
to
b18215c
Compare
b18215c
to
76c1dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the node with the changes and it works as expected. Overall approach LGTM, just a few comments.
b5a9bee
to
292a6d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What was the problem?
This PR resolves #924
How was it solved?
system.backup.height
and updaterpc.allowedMethods
for the default mainnet configHow was it tested?
yarn build
custom-config.json
:./bin/run start -n mainnet -c ./custom-config.json