docker-completion: build from github source tarball

[chenrui333]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

$ /opt/homebrew/Cellar/docker/26.1.3/bin/docker --version
Docker version 26.1.3, build Homebrew

followup #171906

[carlocab]

We can probably keep this in case users rely on it. But we can definitely install the completions from a tarball.

[chenrui333]

why does people reply on it? what is the use case?

[carlocab]

Debugging, perhaps? Presumably if there were no use case upstream wouldn't build this into the output of their version information...

[chenrui333]

for release build, it is not useful (the vcs provider introduced in go1.18 for debugging build), that is why I am also trying to update all the go builds without using git checkout.

[SMillerDev]

I've seen quite some arguments from upstream developers that disagree with that. They generally want to know what commit the versioned build was based on.

[MikeMcQuaid]

We should definitely keep this. I see no reason to ever override GitCommit to not mention a Git commit and, if this has been done on any other formulae, these changes should be reverted.

Suggested change

	-X github.com/docker/cli/cli/version.GitCommit=#{tap.user}
	-X github.com/docker/cli/cli/version.GitCommit=#{Utils.git_short_head}-Homebrew

or something if you really want to identify Homebrew usage here.

[chenrui333]

I've seen quite some arguments from upstream developers that disagree with that. They generally want to know what commit the versioned build was based on.

The version is equivalent to the commit, if we are going to do it, should we revert all the go formulae to the git checkout. (maybe another RFC on this topic?)

[MikeMcQuaid]

I don't think it is equivalent.

should we revert all the go formulae to the git checkout.

or query it from the API?

[chenrui333]

for now, I just revert the docker build change