Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cling 1.0 #171856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cling 1.0 #171856

wants to merge 1 commit into from

Conversation

clashman
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@clashman
Copy link
Author

clashman commented May 16, 2024 •
edited

This is a work in progress:
With the current state of the PR, cling needs to be run with cling -resource-dir /opt/homebrew/Cellar/cling/1.0/libexec/lib/clang/13.0.0, because the default resource dir is /tmp/cling-20240516-{...}build/lib/clang/13.0.0
which is the base directory that homebrew used during compilation.

@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333
Copy link
Member 

  cling
    * Files were found with references to the Homebrew shims directory.
      The offending files are:
        libexec/bin/cling
        libexec/lib/libclingJupyter.dylib
        libexec/lib/libcling.dylib
        libexec/lib/libclingInterpreter.a

@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. audit failure CI fails while auditing the software and removed test failure CI fails while running the test-do block labels May 16, 2024
@clashman clashman mentioned this pull request May 17, 2024
Open
@clashman
Copy link
Author

clashman commented May 17, 2024 •
edited 

  cling
    * Files were found with references to the Homebrew shims directory.
      The offending files are:
        libexec/bin/cling
        libexec/lib/libclingJupyter.dylib
        libexec/lib/libcling.dylib
        libexec/lib/libclingInterpreter.a

Even after reading the source code of the function that throws the error I don't understand what the problem is. Is there any documentation anywhere?

Apparently fgrep is run on Homebrew's shim directory to look for matches of the file names of the files contained in the keg? Please someone enlighten me or point me to the docs. I spent waay to much time on this already.

@chenrui333
Copy link
Member

it is related to superenv https://docs.brew.sh/Formula-Cookbook#superenv-notes

chenrui333
chenrui333 reviewed May 18, 2024
View reviewed changes
Formula/c/cling.rb
Comment on lines -9 to -18
bottle do
sha256 arm64_monterey: "ae9ec74f889a58e57f00394e3b46dd1793d975ce7dc5907c71e2e15853610a62"
sha256 cellar: :any, arm64_big_sur: "82134eeea0ba90008355120b137908d828011e302b62ec97de10b152777d9651"
sha256 monterey: "90f4150c5bcc027fe76db2f53948eb31e757124da337639303eee2ac768c8999"
sha256 cellar: :any, big_sur: "e894d9476bc9ed0edb1ca8d3ca1d9fa6cefc8fc50befc93f1d1c25d1f1bee721"
sha256 cellar: :any, catalina: "fd178b38640189a9b096d9c98fe3b1dedc934a504ddc0d3dc1c6bbfea144f09f"
sha256 cellar: :any, mojave: "5135fc901ba316ca0e02f5598af21cd42a264994111252964f239b2576c7829b"
sha256 x86_64_linux: "315073c45b0684a970493476b9c8476ddf90eb7d69bd5326efdf97b79ec55e25"
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont touch the bottle block

chenrui333
chenrui333 reviewed May 18, 2024
View reviewed changes
Formula/c/cling.rb
sha256 x86_64_linux: "315073c45b0684a970493476b9c8476ddf90eb7d69bd5326efdf97b79ec55e25"
end

# Does not build on Ventura
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ventura build still failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clashman @chenrui333