Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgccjit: add RPATH reference on Intel macOS #171811

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fixes Homebrew/discussions#5364.

Also, update the test to avoid breaking this again.

@carlocab carlocab force-pushed the libgccjit-rpath branch 2 times, most recently from 8466f8a to 55543e2 Compare May 15, 2024 17:42
@p-linnane p-linnane requested review from Bo98 and fxcoudert May 15, 2024 18:19
@carlocab carlocab force-pushed the libgccjit-rpath branch 3 times, most recently from 71b3180 to 3192c6e Compare May 18, 2024 18:13
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 18, 2024
@carlocab
Copy link
Member Author

Linux is failing because it can't find the zlib headers. Maybe related to the removal of zlib from the Docker container? CC @Bo98

@Bo98
Copy link
Member

Bo98 commented May 19, 2024

Looks like this has never been using Homebrew zlib properly then 🙂

Upstream zlib detection doesn't look like it's very good: https://github.com/gcc-mirror/gcc/blob/releases/gcc-14.1.0/config/zlib.m4. So sounds like we have to pass CFLAGS ourselves, unlike every other dependency where we can pass it properly as an option.

Fixes Homebrew/discussions#5364.

Also, update the test to avoid breaking this again.
@carlocab carlocab added long build Needs CI-long-timeout ready to merge PR can be merged once CI is green labels May 22, 2024
@carlocab carlocab requested a review from a team May 22, 2024 06:44
@carlocab
Copy link
Member Author

Note: there is an alternative approach at #171822.

@fxcoudert
Copy link
Member

Thanks @carlocab

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 2be9586 May 22, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the libgccjit-rpath branch May 22, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Needs CI-long-timeout ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants