-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PortX 2.2.6 #174082
PortX 2.2.6 #174082
Conversation
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The livecheck
block makes sense to me. The latest
dmg file is linked from the download page and the hash in the URL (0ac7ea20
) is the same in the available archive.org snapshots from 2023 (albeit, there are only two to compare). Hopefully the hash doesn't change with website updates but we can address that if/when it happens.
I'll leave overall review to our cask maintainers but it looks fine to me.
This is fine for me, but I'd like to avoid @NetSarangComputer it would be very helpful to have a method to get version information without needing to download 2 * 100mb files. Please consider publishing that information. Thanks |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.