Use normalize-newlines algorithm for setCustomValidity #10350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
May 15, 2024
sefeng211
force-pushed
the
normalize-newline-custom-validity
branch
from
2704544
to
3240163
Compare
|
Yeah I plan to write a test case for this |
|
@annevk Anne I've added the test as part of my Gecko changes. Do you think we can merge the PR? I am not sure a MDN issue is needed, I guess not? |
annevk
approved these changes
May 17, 2024
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 17, 2024
This is for whatwg/html#10350 Differential Revision: https://phabricator.services.mozilla.com/D210688 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1896923 gecko-commit: c9931f28fd168fb6f179eecf28a87a1a738fde0d gecko-reviewers: emilio
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 17, 2024
…r=emilio This is for whatwg/html#10350 Differential Revision: https://phabricator.services.mozilla.com/D210688
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 18, 2024
This is for whatwg/html#10350 Differential Revision: https://phabricator.services.mozilla.com/D210688 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1896923 gecko-commit: c9931f28fd168fb6f179eecf28a87a1a738fde0d gecko-reviewers: emilio
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 20, 2024
…r=emilio This is for whatwg/html#10350 Differential Revision: https://phabricator.services.mozilla.com/D210688
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 30, 2024
…r=emilio This is for whatwg/html#10350 Differential Revision: https://phabricator.services.mozilla.com/D210688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10339
(See WHATWG Working Mode: Changes for more details.)
/form-control-infrastructure.html ( diff )