Upstream Trusted Types protection of timer functions #10348
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
force-pushed
the
tt-timers
branch
2 times, most recently
from
9f3a6a6
to
8c6360d
Compare
zcorpan
reviewed
May 20, 2024
zcorpan
approved these changes
May 31, 2024
|
Looks good, but needs a rebase. |
annevk
reviewed
May 31, 2024
source
Outdated
| <var>repeat</var> is true; "<code data-x=""> setTimeout</code>" otherwise.</p></li> | ||
|
|
||
| <li><p>Let <var>sink</var> be a concatenation of <var>globalName</var> and | ||
| <var>methodName</var>.</p></li> |
There was a problem hiding this comment.
I think it would be clearer to insert the space here. Folks might well miss that it's part of the method name string.
There was a problem hiding this comment.
Done, definitely reads a bit more explicitly now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )