[XLA] Error out when encountering errors during flag parsing #67824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_634688772
branch
3 times, most recently
from
8afa88d
to
2ea193e
Compare
Currently we crash on unknown flags left after XLA_FLAGS parsing, but all the errors are just silently ignored. This leaves a large footgun which ignores failed flags. PiperOrigin-RevId: 635098018
copybara-service
bot
force-pushed
the
exported_pr_634688772
branch
from
2ea193e
to
c57ab0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA] Error out when encountering errors during flag parsing
Currently we crash on unknown flags left after XLA_FLAGS parsing, but all the
errors are just silently ignored. This leaves a large footgun which ignores
failed flags.