-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub actions versions #8689
base: develop
Are you sure you want to change the base?
Conversation
aa68397
to
d509a0f
Compare
704f570
to
c6950cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM 👍 but I would not apply the updates to the cypress job since we will have that removed anyways soon, and the update makes it a lot more complicated to use since the updates will be spread out in 8 files. The uploads for constraints seems fine, but we should probably monitor after the merge that it gets updated correctly in the constraints-develop
and constraints-release
branch.
c6950cb
to
63daff5
Compare
63daff5
to
b9cdb7b
Compare
Yeah good point, I have reverted the changes for the cypress workflows. |
Describe your changes
Update our GitHub actions versions to fix the deprecation warning:
With
actions/upload-artifact@v4
, multiple jobs cannot upload to the same folder anymore. Hence, I have updated the flows according to this migration guide. See also this discussion: actions/upload-artifact#478The workflows for cypress are kept on
v3
according to this comment to keep the usage of it simple until we retire it soonish.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.