Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions versions #8689

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

raethlein
Copy link
Collaborator

@raethlein raethlein commented May 16, 2024

Describe your changes

Update our GitHub actions versions to fix the deprecation warning:

Screenshot 2024-05-16 at 11 47 29

With actions/upload-artifact@v4, multiple jobs cannot upload to the same folder anymore. Hence, I have updated the flows according to this migration guide. See also this discussion: actions/upload-artifact#478

The workflows for cypress are kept on v3 according to this comment to keep the usage of it simple until we retire it soonish.

GitHub Issue Link (if applicable)

Testing Plan

  • if the CI workflows run through, we should be all good

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@raethlein raethlein force-pushed the chore/update-deprecated-actions branch from 704f570 to c6950cb Compare May 28, 2024 10:39
Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM 👍 but I would not apply the updates to the cypress job since we will have that removed anyways soon, and the update makes it a lot more complicated to use since the updates will be spread out in 8 files. The uploads for constraints seems fine, but we should probably monitor after the merge that it gets updated correctly in the constraints-develop and constraints-release branch.

@raethlein raethlein force-pushed the chore/update-deprecated-actions branch from c6950cb to 63daff5 Compare May 28, 2024 12:39
@raethlein raethlein force-pushed the chore/update-deprecated-actions branch from 63daff5 to b9cdb7b Compare May 28, 2024 12:42
@raethlein
Copy link
Collaborator Author

Overall, LGTM 👍 but I would not apply the updates to the cypress job since we will have that removed anyways soon, and the update makes it a lot more complicated to use since the updates will be spread out in 8 files. The uploads for constraints seems fine, but we should probably monitor after the merge that it gets updated correctly in the constraints-develop and constraints-release branch.

Yeah good point, I have reverted the changes for the cypress workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants