Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MarkdownColumn #8684

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rgajrawala
Copy link

Describe your changes

I want to display bolded/italicized/underlined parts of text in my dataframe table. So we can use the MarkdownCell from Glide Data Grid.

Others also have similar requests - https://discuss.streamlit.io/t/how-to-display-st-markdown-in-a-column-of-st-dataframe/59301.

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@rgajrawala
Copy link
Author

I didn't see any docs on building streamlit to test changes. Can someone please point me to some docs?

@jrieke
Copy link
Collaborator

jrieke commented May 17, 2024

Hey @rgajrawala! PM from the Streamlit team here. Thanks for the contribution! Lukas (our eng who's working on most dataframe things) is currently out of office but I'll let him have a look when he's back. I think we considered markdown cells in the past but decided against it. I am not entirely sure anymore what the reason was, but I think it was related to markdown cells only showing the formatted markdown text when you double-click in Glide, which is a bit confusing.

Would you mind describing your use case a bit more, i.e. what kind of text you're trying to show and why it needs to be formatted in this way? Also, is it ok for you if this formatting only shows up when you double click the cell or do you want to have it always displayed?

@rgajrawala
Copy link
Author

Hi @jrieke, yes the markdown will only show in the overlay, which is okay for my usecase (showing some text with some parts highlighted). Currently I have to display this info in a separate HTML table from my numerical data in a dataframe table, and I'd like to join the functionality.

@rgajrawala
Copy link
Author

Hi @jrieke, do you know when @LukasMasuch will be back? I'd like to get this in soon if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants