Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Navigation Sections in the Sidebar for MPAv2 #8681

Merged
merged 16 commits into from
May 22, 2024

Conversation

kmcgrady
Copy link
Collaborator

@kmcgrady kmcgrady commented May 15, 2024

Describe your changes

These changes allow SidebarNav to display NavSections.

image
  • The key difference in the screenshots is the absence of the x
  • There's some very minor margin changes

Testing Plan

  • JS unit tests are provided
  • E2E Tests are updated to reflect the new images for MPA v1 mainly.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@kmcgrady kmcgrady force-pushed the feature/sidebar-nav-sections branch from f6a5afb to 0ccacfe Compare May 20, 2024 21:28
@kmcgrady kmcgrady marked this pull request as ready for review May 20, 2024 21:33
@kmcgrady kmcgrady changed the title Feature/sidebar nav sections Support Navigation Sections in the Sidebar for MPAv2 May 21, 2024
Copy link
Collaborator

@vdonato vdonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth getting a second review as I'm less confident in CSS best-practices, but all of the non styling things LGTM

@kmcgrady kmcgrady merged commit 38ade8b into feature/mpa-v2 May 22, 2024
31 checks passed
@kmcgrady kmcgrady deleted the feature/sidebar-nav-sections branch May 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants