Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update website to pydata-sphinx-theme #29035

Closed
wants to merge 30 commits into from

Conversation

Charlie-XIAO
Copy link
Contributor

Reference Issues/PRs

Closes #28084. WIP.

Charlie-XIAO and others added 29 commits January 31, 2024 18:50
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
…es (scikit-learn#28623)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Copy link

github-actions bot commented May 17, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0a60e17. Link to the linter CI: here

@Charlie-XIAO Charlie-XIAO changed the title New web theme DOC Update website to pydata-sphinx-theme May 17, 2024
@adrinjalali
Copy link
Member

@Charlie-XIAO you probably want to have a PR merging main repo's new_web_theme into main instead.

@Charlie-XIAO
Copy link
Contributor Author

Charlie-XIAO commented May 17, 2024

I was somehow trying to avoid myself accidentally messing up the main branch after I got the access 🤣 but okay I will reopen the PR from there.

@adrinjalali
Copy link
Member

😆 yeah opening such PRs can be scary.

I personally have a separate clone locally which has write access to the main repo (my usual clone doesn't), to make it a bit more conscious when dealing with such PRs.

@adrinjalali
Copy link
Member

Note that you don't have to do anything locally in this regard though. You can do everything through PRs to the new_web_theme of the main repo from your fork.

@Charlie-XIAO
Copy link
Contributor Author

So essentially I should open a final cleanup PR targeting the new_web_theme branch, after which we should directly be able to merge new_web_theme back to main.

@adrinjalali
Copy link
Member

The merging would also be through a PR, I opened it here: #29038, feel free to take over the PR. Once we're happy with the state of the new_web_theme branch, we simply hit merge on that PR.

@Charlie-XIAO
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC Update website to pydata-sphinx-theme
2 participants