Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Remove some dead code from BlockList #45398

Merged
merged 9 commits into from
May 20, 2024
Merged

[Data] Remove some dead code from BlockList #45398

merged 9 commits into from
May 20, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

This PR removes several methods from BlockList and LazyBlockList that aren't used anywhere.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Remove daed blocklist code
ca4b264 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Initial commit
de467bb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani and others added 6 commits May 16, 2024 17:48
@bveeramani
Remove another method
be819d5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Add another method
bd1aea8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@can-anyscale
Merge branch 'master' into dead-block-list
99422e6
@bveeramani
Remove function
c5559d8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'dead-block-list' of https://github.com/bveeramani/ray i…
88fdf7d 
…nto dead-block-list

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Fix test
5a7f2b0 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani enabled auto-merge (squash) May 20, 2024 22:25
@github-actions github-actions bot added the go Trigger full test run on premerge label May 20, 2024
@bveeramani
Fix test
bacd3a5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@github-actions github-actions bot disabled auto-merge May 20, 2024 23:10
@bveeramani bveeramani enabled auto-merge (squash) May 20, 2024 23:55
@bveeramani bveeramani merged commit 348145c into ray-project:master May 20, 2024
7 checks passed
@bveeramani bveeramani deleted the dead-block-list branch May 21, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@c21 c21

Labels
go Trigger full test run on premerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bveeramani @c21 @can-anyscale