Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cluster launcher] [Azure] add option for eviction policy in azure VM template #45397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bthananjeyan
Copy link

@bthananjeyan bthananjeyan commented May 17, 2024

Why are these changes needed?

This is necessary to give users the option to pick an eviction policy (Delete vs Deallocate) when nodes in the cluster are pre-empted.

This exposes an additional option that can be set in the node_config attribute in the cluster YAML file.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bthananjeyan
Copy link
Author

@architkulkarni @ericl @hongchaodeng please let me know if you have any feedback on this PR, or if there is someone else who should be assigned to review it. Thanks!

@bthananjeyan bthananjeyan force-pushed the brijen/delete-template branch 3 times, most recently from 3967ace to 729bdca Compare May 28, 2024 18:55
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels May 29, 2024
Signed-off-by: bthananjeyan <brijen@ambirobotics.com>
@bthananjeyan
Copy link
Author

@architkulkarni @ericl @hongchaodeng bumping this PR in case it was buried. Please let me know if you have any feedback, or if someone else can be assigned to it. I don't have the ability to assign reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants