Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Issue 44686: Upgrade all rllib_contrib requirements to tf2.11.1. #45396

Merged
merged 1 commit into from
May 17, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented May 16, 2024

Issue 44686: Upgrade all rllib_contrib requirements to tf2.11.1.

Why are these changes needed?

Closes #44686

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues security The issue or proposal related to security rllib-contrib Issues related to algorithms in rllib-contrib labels May 16, 2024
@anyscalesam
Copy link
Collaborator

@sven1977 WDY need from me; do you want my code review?

@sven1977
Copy link
Contributor Author

I think I need someone's approval :) Lemme check, who the code-owners of rllib_contrib are ...

@sven1977
Copy link
Contributor Author

Can you try approving @anyscalesam or @zhe-thoughts ? Then we can merge this.

@sven1977
Copy link
Contributor Author

It's just the version upgrades.

@anyscalesam anyscalesam self-requested a review May 16, 2024 23:03
@anyscalesam
Copy link
Collaborator

@sven1977 approved

@sven1977 sven1977 enabled auto-merge (squash) May 17, 2024 03:52
@github-actions github-actions bot added the go Trigger full test run on premerge label May 17, 2024
@sven1977 sven1977 merged commit faab1ac into ray-project:master May 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Trigger full test run on premerge rllib RLlib related issues rllib-contrib Issues related to algorithms in rllib-contrib security The issue or proposal related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RLLib] Critical Tensorflow CVE - CVE-2023-25664
4 participants