[serve] allow build_serve_application to happen in parallel #45394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Proposal based on the conversation here.
We are using the Multi-app containers pattern and have a large number of apps, and each of the images is quite large (ray-gpu base + our own dependencies). We run KubeRay and have noticed that the call to build all the apps for a deploy is run from the ServeController, which runs on the head node. Practically the head node will never need any of these images, but that is mostly a separate issue. The main bottleneck is that if all of these build tasks are going to be run on the head anyway, we'd like to at least do them in parallel.
The supporting code comment seems to intend to kick off a job, but the decorator here limits concurrency, and I don't think you can override this via
options
at the call site.Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.