-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Enhance callbacks test case for EnvRunners; Add (optional) explicit enable_multi_agent
setting to AlgorithmConfig.
#45385
base: master
Are you sure you want to change the base?
Conversation
…callbacks_test_case_for_env_remaining_the_same Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/algorithms/algorithm_config.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -2409,6 +2411,17 @@ def multi_agent( | |||
of IDs is properly converted into a dict mapping these IDs to PolicySpecs. | |||
|
|||
Args: | |||
enable_multi_agent: Whether multi-agent mode should be manually enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which use case does this play a role? Are there users with environments that are multi-agent, but can be played single-agent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the case, if we train only a single policy and there are jultiple agents in the environment using all this single policy. Got you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, correct.
…callbacks_test_case_for_env_remaining_the_same
enable_multi_agent
setting to AlgorithmConfigWhy are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.