-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-automation] Separate steps into groups #45355
Conversation
Signed-off-by: khluu <51931015+khluu@users.noreply.github.com>
I tested with this build and was able to see each of the group start "waiting for agent" right after unblocking without waiting for other steps: https://buildkite.com/ray-project/release-automation/builds/476#_ |
isn't it easier to just add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it easier to just add the depends_on for steps? rather than breaking it down into pieces?
like each group now only contains 1 or 2 command steps.
for example, mac sanity checks don't really have any |
why? that is how it supposed to work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why using depends_on
key does not work here..
@aslonnie You can take a look at this commit: 30fdfe8 which I set mac sanity check step to depend on its block step. The block step is blocked by the step before it though for some reason: https://buildkite.com/ray-project/release-automation/builds/474/dag When I unblocked the step, the mac sanity check steps didn't even run or wait for agent .. they were just stuck there |
you need to add an empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this:
depends_on
). This happens for mac sanity check step since it has no dependency: https://buildkite.com/ray-project/release-automation/builds/470/dagforge-arm64
->forge_arm64