Use float data type for Half var_sum in batchnorm stats updating on CPU #126525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126525
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fb6860f with merge base 8a45979 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
CaoE
changed the title
jgong5
approved these changes
May 24, 2024
Comment on lines
+214
to
+216
| if (dtype == kHalf) { | ||
| dtype = kFloat; | ||
| } |
There was a problem hiding this comment.
Add some comments here to explain why we are doing so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using float data type for Half
var_sumin batchnorm stats updating on CPU to avoidvar_sumoverflow since the representation range of Half is small.