Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Vectorize more dtype for int4mm #126512

Closed
wants to merge 1 commit into from
Closed

[Perf] Vectorize more dtype for int4mm #126512

wants to merge 1 commit into from
+85 −9

Conversation

malfet
Copy link
Contributor

@malfet malfet commented May 17, 2024 •
edited

It used to be vectorized only for f16, but no reason not to do the same for bf16 or f32

Spiritual followup of #125290

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@malfet
[Perf] Vectorize more dtype for int4mm
5fff689 
It used to be vectorized only for f16, but no reason not to do the same for bf16 or f32

Spiritual followup of #125290
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label May 17, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 17, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126512

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5fff689 with merge base e3c5d1b (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added topic: improvements topic category release notes: performance_as_product release notes category ciflow/trunk Trigger trunk jobs on your pull request ciflow/aarch64 labels May 17, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 17, 2024

Warning: Unknown label ciflow/aarch64.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_conda
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/inductor
  • ciflow/inductor-perf-compare
  • ciflow/inductor-micro-benchmark
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/rocm
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu
  • ciflow/torchbench

Please add the new label to .github/pytorch-probot.yml

@malfet malfet added the ciflow/linux-aarch64 linux aarch64 CI workflow label May 17, 2024
@malfet
Copy link
Contributor Author

malfet commented May 17, 2024

@pytorchbot merge -f "Lint , Mac test and aarch64 builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@malfet @ZelboK
[Perf] Vectorize more dtype for int4mm (pytorch#126512)
e24f7b3 
It used to be vectorized only for f16, but no reason not to do the same for bf16 or f32

Spiritual followup of pytorch#125290

Pull Request resolved: pytorch#126512
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mingfeima mingfeima Awaiting requested review from mingfeima

@mikekgfb mikekgfb Awaiting requested review from mikekgfb

@jgong5 jgong5 Awaiting requested review from jgong5

Assignees
No one assigned
Labels
ciflow/aarch64 ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) release notes: performance_as_product release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malfet @pytorchmergebot @Skylion007