Remove unnecessary implementations from MockHandler #126511

ezyang · 2024-05-17T05:13:40Z

Stack from ghstack (oldest at bottom):

Dead implementations are confusing and can cause bugs when people
accidentally hit them. Better for it to be missing.

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-05-17T05:13:43Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126511

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (10 Unrelated Failures)

As of commit f16848d with merge base 6bcf156 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.1-py3.12-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
inductor/test_torchinductor.py::GPUTests::test_config_option_dont_assume_alignment_cuda
inductor / rocm6.1-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2) (gh) (trunk failure)
Process completed with exit code 2.

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#120841)
hf_BigBird
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#120841)
hf_BigBird
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu, unstable) (gh) (#120841)
Process completed with exit code 2.
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#120841)
hf_BigBird
inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable) (gh) (#120841)
Process completed with exit code 2.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Dead implementations are confusing and can cause bugs when people accidentally hit them. Better for it to be missing. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 257b37bdde1b69cf79313b3afb0192ad15d18f61 Pull Request resolved: #126511

Skylion007 · 2024-05-17T13:53:11Z

torch/_inductor/ops_handler.py

-        for name, format_string in itertools.chain(
-            magic_methods.items(), inplace_methods.items()
-        ):
+        for name, format_string in {


Why this chain?

err, chain?

[ghstack-poisoned]

ezyang · 2024-05-17T18:02:01Z

@pytorchbot merge

pytorchmergebot · 2024-05-17T18:04:36Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-05-17T18:20:33Z

Merge failed

Reason: 18 jobs have failed, first few of them are: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu, unstable)

Details for Dev Infra team

Raised by workflow job

lezcano

Yay, div is gone!!

ezyang · 2024-05-19T04:41:59Z

@pytorchbot merge -f "confirmed not my problem"

pytorchmergebot · 2024-05-19T04:43:39Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #126553 Approved by: https://github.com/lezcano, https://github.com/Skylion007 ghstack dependencies: #126511

Dead implementations are confusing and can cause bugs when people accidentally hit them. Better for it to be missing. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#126511 Approved by: https://github.com/peterbell10, https://github.com/lezcano

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#126553 Approved by: https://github.com/lezcano, https://github.com/Skylion007 ghstack dependencies: pytorch#126511

Update

1f46a9e

[ghstack-poisoned]

ezyang mentioned this pull request May 17, 2024

Update ops handler documentation some more #126480

Closed

pytorch-bot bot added ciflow/inductor module: inductor labels May 17, 2024

github-actions bot requested review from albanD, antoniojkim, bdhirsh, miladm and SherlockNoMad May 17, 2024 05:13

Skylion007 reviewed May 17, 2024

View reviewed changes

peterbell10 approved these changes May 17, 2024

View reviewed changes

Update

f16848d

[ghstack-poisoned]

This was referenced May 17, 2024

Teach FakeTensor to fill in item_memo when converting scalar CPU tensor #126245

Closed

UFMT torch.utils._sympy.functions #126553

Closed

[WIP] tensorify #125423

Open

ezyang added the topic: not user facing topic category label May 17, 2024

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024

pytorchmergebot added the merging label May 17, 2024

pytorchmergebot removed the merging label May 17, 2024

lezcano approved these changes May 17, 2024

View reviewed changes

pytorchmergebot added the merging label May 19, 2024

pytorchmergebot closed this in 7dae7d3 May 19, 2024

pytorchmergebot added Merged and removed merging labels May 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unnecessary implementations from MockHandler #126511

Remove unnecessary implementations from MockHandler #126511

ezyang commented May 17, 2024 •

edited

pytorch-bot bot commented May 17, 2024 •

edited

Skylion007 May 17, 2024

ezyang May 17, 2024

ezyang commented May 17, 2024

pytorchmergebot commented May 17, 2024

pytorchmergebot commented May 17, 2024

lezcano left a comment

ezyang commented May 19, 2024

pytorchmergebot commented May 19, 2024

Remove unnecessary implementations from MockHandler #126511

Remove unnecessary implementations from MockHandler #126511

Conversation

ezyang commented May 17, 2024 • edited

pytorch-bot bot commented May 17, 2024 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126511

✅ You can merge normally! (10 Unrelated Failures)

Skylion007 May 17, 2024

Choose a reason for hiding this comment

ezyang May 17, 2024

Choose a reason for hiding this comment

ezyang commented May 17, 2024

pytorchmergebot commented May 17, 2024

Merge started

pytorchmergebot commented May 17, 2024

Merge failed

lezcano left a comment

Choose a reason for hiding this comment

ezyang commented May 19, 2024

pytorchmergebot commented May 19, 2024

Merge started

ezyang commented May 17, 2024 •

edited

pytorch-bot bot commented May 17, 2024 •

edited