integrate it with pytorch #126508
Closed
integrate it with pytorch #126508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126508
Note: Links to docs will display an error until the docs builds have been completed. ❌ 22 New FailuresAs of commit 10ffc99 with merge base 7e9a037 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D57172228 |
fenypatel99
force-pushed
the
export-D57172228
branch
from
23d4c0e
to
00e8fd0
Compare
fenypatel99
added a commit
to fenypatel99/pytorch
that referenced
this pull request
May 17, 2024
Summary: integrate workloadd events with pytorch Test Plan: CIs Differential Revision: D57172228
|
This pull request was exported from Phabricator. Differential Revision: D57172228 |
aaronenyeshi
requested changes
May 17, 2024
| @@ -362,6 +363,18 @@ c10::DeviceType deviceTypeFromActivity(libkineto::ActivityType activity_type) { | |||
| }(); | |||
| return device_type; | |||
| } | |||
| case libkineto::ActivityType::MTIA_WORKLOADD: { | |||
There was a problem hiding this comment.
You can combine this option to line 354, instead of duplicating this block
Summary: integrate workloadd events with pytorch Test Plan: CIs Differential Revision: D57172228
fenypatel99
force-pushed
the
export-D57172228
branch
from
00e8fd0
to
10ffc99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57172228 |
|
This pull request was exported from Phabricator. Differential Revision: D57172228 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D57172228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D57172228