Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ConcatDataset.cumsum #126506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify ConcatDataset.cumsum #126506

wants to merge 2 commits into from

Conversation

OverLordGoldDragon
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 17, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126506

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 80125da with merge base da1fc85 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label May 17, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 17, 2024 •
edited

CLA Not Signed

@OverLordGoldDragon OverLordGoldDragon changed the title Replace def cumsum with its equivalent (dataset.py) Simplify ConcatDataset.cumsum May 17, 2024
@OverLordGoldDragon
Copy link
Contributor Author

https://pytorch.org/blog/a-contributor-license-agreement-for-pytorch/

PyTorch’s BSD license is not changing. There is no impact to PyTorch users. CLAs will only be required for new contributions to the project. For past contributions, no action is necessary. Everything else stays the same, whether it’s IP ownership, workflows, contributor roles or anything else that you’ve come to expect from PyTorch.

I'm an existing contributor, why am I required to sign?

@andrewkho
Copy link
Contributor

@OverLordGoldDragon can you please update the description with why you want to make this change?

@OverLordGoldDragon
Copy link
Contributor Author

I might not sign this CLA and not contribute further. Can someone answer my question?

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 21, 2024
@OverLordGoldDragon OverLordGoldDragon mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkho andrewkho Awaiting requested review from andrewkho andrewkho is a code owner

@gokulavasan gokulavasan Awaiting requested review from gokulavasan gokulavasan is a code owner

Assignees
No one assigned
Labels
open source release notes: dataloader release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OverLordGoldDragon @andrewkho @pytorchbot @mikaylagawarecki