Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing scheduler.py [3/3]: update types #126505

Closed
wants to merge 8 commits into from

Conversation

aorenste
Copy link
Contributor

@aorenste aorenste commented May 17, 2024

Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs.

Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime.

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126505

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 16 Unrelated Failures

As of commit 22945db with merge base a44d0cf (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

aorenste added a commit that referenced this pull request May 17, 2024
ghstack-source-id: 5786e4c29402a496633d560c2cbcda3df05b292b
Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 17, 2024
ghstack-source-id: 393328837e0351eb0abf26019f6953d7aa2ba3ea
Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 17, 2024
ghstack-source-id: 2579d42c0c2ce7326ed19456c262dcd7deb21525
Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 18, 2024
ghstack-source-id: 8b1bfc03b336d06f8bf82296ae80b9f8bd4c626d
Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 18, 2024
ghstack-source-id: b235bf7fed305200a87cd35c97108e666501732f
Pull Request resolved: #126505
@aorenste aorenste changed the title WIP: fix typing in scheduler.py typing scheduler.py [4/4]: update types May 18, 2024
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs.

Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime.




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 18, 2024
ghstack-source-id: 1a0b72caf395f822a9e6fed0012becf1a3acbe36
Pull Request resolved: #126505
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs.

Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime.




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 18, 2024
ghstack-source-id: d92a2a7d7b64fb3acac10afa00b0b6133d8725b6
Pull Request resolved: #126505
@aorenste aorenste changed the title typing scheduler.py [4/4]: update types typing scheduler.py [3/3]: update types May 18, 2024
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs.

Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime.




cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
aorenste added a commit that referenced this pull request May 18, 2024
ghstack-source-id: f51f2948b57d8feaad86c1d56c76cb22e7177e1d
Pull Request resolved: #126505
@aorenste aorenste closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant