-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing scheduler.py [3/3]: update types #126505
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: 5786e4c29402a496633d560c2cbcda3df05b292b Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: 393328837e0351eb0abf26019f6953d7aa2ba3ea Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: 2579d42c0c2ce7326ed19456c262dcd7deb21525 Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This was referenced May 18, 2024
aorenste
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: 8b1bfc03b336d06f8bf82296ae80b9f8bd4c626d Pull Request resolved: #126505
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: b235bf7fed305200a87cd35c97108e666501732f Pull Request resolved: #126505
aorenste
changed the title
WIP: fix typing in scheduler.py
typing scheduler.py [4/4]: update types
May 18, 2024
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs. Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: 1a0b72caf395f822a9e6fed0012becf1a3acbe36 Pull Request resolved: #126505
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs. Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: d92a2a7d7b64fb3acac10afa00b0b6133d8725b6 Pull Request resolved: #126505
aorenste
changed the title
typing scheduler.py [4/4]: update types
typing scheduler.py [3/3]: update types
May 18, 2024
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs. Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
aorenste
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: f51f2948b57d8feaad86c1d56c76cb22e7177e1d Pull Request resolved: #126505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns on disallow-untyped-defs in scheduler.py and then fixes all the fallout that occurs.
Most of these I was able to derive by just reading the code and following the types around - but some I needed to actually instrument the code to see what types were flowing through at runtime.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang