Move MKLDNN Specific IR to Separate File #126504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126504
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 48d528a with merge base 35ea5c6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
leslie-fang-intel
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: 842a6b0e6e572382bd329db6021512e7401730ef Pull Request resolved: #126504
leslie-fang-intel
added
ciflow/trunk
**Summary** Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
May 17, 2024
ghstack-source-id: 5501521a32e5c849a9a18b5267ead37d689392b0 Pull Request resolved: #126504
|
Large amount of code changes is fine for this PR. |
desertfire
approved these changes
May 17, 2024
jgong5
approved these changes
May 20, 2024
|
Yes skipping sanity check is fine for code movement. |
**Summary** Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. cc albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
May 21, 2024
ghstack-source-id: e1b31c9b43dbff82f32492248210ccc8dac2a6b3 Pull Request resolved: #126504
**Summary** Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. cc albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
This was referenced May 24, 2024
leslie-fang-intel
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 5acfe66afdaba06546e40fd4b2b986361bd8f161 Pull Request resolved: #126504
**Summary** Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. cc albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: b69b10960c5cf38e31a66fe6d4ff78ba7ada4aac Pull Request resolved: #126504
**Summary** Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. cc albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 174a9ee46205699090b103322024cd658624a705 Pull Request resolved: #126504
**Summary** Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. cc albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
May 25, 2024
ghstack-source-id: adbc9a038547de22c976e29b945586fcc740f976 Pull Request resolved: #126504
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
added a commit
that referenced
this pull request
May 27, 2024
This reverts commit bf2909b. Reverted #126504 on behalf of https://github.com/DanilBaibak due to Blocks reverting of the broken PR ([comment](#126841 (comment)))
|
@leslie-fang-intel your PR has been successfully reverted. |
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
**Summary** Following the discussion in pytorch#122593 (comment), Move Inductor MKLDNN specific IRs to a separate file. Pull Request resolved: pytorch#126504 Approved by: https://github.com/desertfire, https://github.com/jgong5 ghstack dependencies: pytorch#126841, pytorch#126940
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
This reverts commit bf2909b. Reverted pytorch#126504 on behalf of https://github.com/DanilBaibak due to Blocks reverting of the broken PR ([comment](pytorch#126841 (comment)))
Aidyn-A
pushed a commit
to tinglvv/pytorch
that referenced
this pull request
May 30, 2024
This reverts commit bf2909b. Reverted pytorch#126504 on behalf of https://github.com/DanilBaibak due to Blocks reverting of the broken PR ([comment](pytorch#126841 (comment)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Following the discussion in #122593 (comment), Move Inductor MKLDNN specific IRs to a separate file.
cc @albanD @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang