Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass model path to observer #126503

Closed
wants to merge 1 commit into from
Closed

Conversation

weih9
Copy link
Contributor

@weih9 weih9 commented May 17, 2024

Summary: Passing model path to observer so that they can get additional info if needed.

Test Plan: contbuild & OSS CI

Differential Revision: D57475129

Copy link

pytorch-bot bot commented May 17, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @weih9, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

Copy link

linux-foundation-easycla bot commented May 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the release notes: mobile release notes category label May 17, 2024
Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126503

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 638f2b9 with merge base 66dc8fb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57475129

@weih9
Copy link
Contributor Author

weih9 commented May 17, 2024

/easycla

Copy link

pytorch-bot bot commented May 17, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @weih9, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

Summary:

Passing model path to observer so that they can get additional info if needed.

Test Plan: contbuild & OSS CI

Reviewed By: kirklandsign

Differential Revision: D57475129
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57475129

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

Copy link

pytorch-bot bot commented May 18, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@DanilBaibak
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 20, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: mobile release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants